Automated Tests #12
Merged
Automated Tests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds automated testing infrastructure and implements several bug fixes and feature enhancements to the API. The main purpose is to establish comprehensive automated testing capabilities while fixing issues related to event data processing, file naming consistency, and API endpoint improvements.
Key changes include:
- Comprehensive automated test suite with Selenium WebDriver for end-to-end testing
- Bug fixes for R2R event indexing in event data processing and file naming consistency across services
- Enhanced event data API with new instrument endpoint and improved parameter handling
Reviewed Changes
Copilot reviewed 32 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ | Complete automated test suite with Node.js scripts for API endpoints, Selenium tests for UI, Docker configuration, and test data files |
| api/events/ | Enhanced event data processing with R2R event support, new instruments endpoint, and improved parameter handling |
| api/stations/api.py | Added token authorization to nearest_station endpoint |
| api/core/views.py | Fixed column name references for underway data display and enhanced CTD plot response headers |
| api/underway/ | Added clean_column_names utility integration and fixed file naming consistency |
| api/*/services.py | Consistent lowercase file naming across multiple service modules |
| docker-compose-testing.yml | Docker configuration for automated testing environment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
correct punctuation Co-authored-by: Copilot <[email protected]>
|
Everything working well locally, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Need to rerun importunderwaydata after merging this PR.